glyphdiff.com/frontend-svelte
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: add generic type for property value

Browse Source
This commit is contained in:
Ilia Mashkov
2026-01-09 16:11:35 +03:00
parent 6f7e863b13
commit 1990860717
6 changed files with 52 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/shared/ui/CheckboxFilter/CheckboxFilter.svelte.test.ts
View File

@@ -33,7 +33,7 @@ describe('CheckboxFilter Component', () => {
/**
* Helper function to create a filter for testing
*/
function createTestFilter(properties: Property[]) {
function createTestFilter<T extends string>(properties: Property<T>[]) {
return createFilter({ properties });
}
@@ -44,6 +44,7 @@ describe('CheckboxFilter Component', () => {
return Array.from({ length: count }, (_, i) => ({
id: `prop-${i}`,
name: `Property ${i}`,
value: `Value ${i}`,
selected: selectedIndices.includes(i),
}));
}
@@ -437,10 +438,11 @@ describe('CheckboxFilter Component', () => {
describe('Edge Cases', () => {
it('handles long property names', () => {
const properties: Property[] = [
const properties: Property<string>[] = [
{
id: '1',
name: 'This is a very long property name that might wrap to multiple lines',
value: '1',
selected: false,
},
];
@@ -458,10 +460,10 @@ describe('CheckboxFilter Component', () => {
});
it('handles special characters in property names', () => {
const properties: Property[] = [
{ id: '1', name: 'Café & Restaurant', selected: true },
{ id: '2', name: '100% Organic', selected: false },
{ id: '3', name: '(Special) <Characters>', selected: false },
const properties: Property<string>[] = [
{ id: '1', name: 'Café & Restaurant', value: '1', selected: true },
{ id: '2', name: '100% Organic', value: '2', selected: false },
{ id: '3', name: '(Special) <Characters>', value: '3', selected: false },
];
const filter = createTestFilter(properties);
render(CheckboxFilter, {
@@ -475,8 +477,8 @@ describe('CheckboxFilter Component', () => {
});
it('handles single property filter', () => {
const properties: Property[] = [
{ id: '1', name: 'Only One', selected: true },
const properties: Property<string>[] = [
{ id: '1', name: 'Only One', value: '1', selected: true },
];
const filter = createTestFilter(properties);
render(CheckboxFilter, {
@@ -527,12 +529,12 @@ describe('CheckboxFilter Component', () => {
describe('Component Integration', () => {
it('works correctly with real filter data', async () => {
const realProperties: Property[] = [
{ id: 'sans-serif', name: 'Sans-serif', selected: true },
{ id: 'serif', name: 'Serif', selected: false },
{ id: 'display', name: 'Display', selected: false },
{ id: 'handwriting', name: 'Handwriting', selected: true },
{ id: 'monospace', name: 'Monospace', selected: false },
const realProperties: Property<string>[] = [
{ id: 'sans-serif', name: 'Sans-serif', value: 'sans-serif', selected: true },
{ id: 'serif', name: 'Serif', value: 'serif', selected: false },
{ id: 'display', name: 'Display', value: 'display', selected: false },
{ id: 'handwriting', name: 'Handwriting', value: 'handwriting', selected: true },
{ id: 'monospace', name: 'Monospace', value: 'monospace', selected: false },
];
const filter = createTestFilter(realProperties);
render(CheckboxFilter, {